Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus metrics for number of badge update pushes. #4709

Merged
merged 2 commits into from Feb 22, 2019

Conversation

3 participants
@richvdh
Copy link
Member

richvdh commented Feb 21, 2019

We're counting the number of push notifications, but not the number of badges;
I'd like to see if they are significant.

Add prometheus metrics for number of badge update pushes.
We're counting the number of push notifications, but not the number of badges;
I'd like to see if they are significant.

@richvdh richvdh requested a review from matrix-org/core-team Feb 21, 2019

defer.returnValue(False)
rejected = []
if 'rejected' in resp:
rejected = resp['rejected']

This comment has been minimized.

@erikjohnston

erikjohnston Feb 21, 2019

Member

Isn't this important?

This comment has been minimized.

@richvdh

richvdh Feb 21, 2019

Author Member

well, maybe, but we don't use it.

This comment has been minimized.

@erikjohnston
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 21, 2019

Codecov Report

Merging #4709 into develop will increase coverage by 0.17%.
The diff coverage is 85.71%.

@@             Coverage Diff             @@
##           develop    #4709      +/-   ##
===========================================
+ Coverage    74.98%   75.16%   +0.17%     
===========================================
  Files          340      340              
  Lines        34814    34815       +1     
  Branches      5702     5702              
===========================================
+ Hits         26107    26168      +61     
+ Misses        7085     7036      -49     
+ Partials      1622     1611      -11

@richvdh richvdh requested a review from matrix-org/synapse-core Feb 21, 2019

@richvdh richvdh added this to To Do in Homeserver Task Board via automation Feb 21, 2019

@richvdh richvdh moved this from To Do to In progress in Homeserver Task Board Feb 21, 2019

@richvdh richvdh merged commit e07384c into develop Feb 22, 2019

7 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 85.71% of diff hit (target 0%)
Details
codecov/project 75.16% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Homeserver Task Board automation moved this from In progress to Done Feb 22, 2019

@richvdh richvdh deleted the rav/badge_push_metrics branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.