Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix state cache invalidation on workers #4715

Merged
merged 2 commits into from Feb 22, 2019

Conversation

Projects
None yet
3 participants
@erikjohnston
Copy link
Member

erikjohnston commented Feb 22, 2019

Broke by #4671

erikjohnston added some commits Feb 22, 2019

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Feb 22, 2019

@erikjohnston

This comment has been minimized.

Copy link
Member Author

erikjohnston commented Feb 22, 2019

Fixes #4702

@richvdh
Copy link
Member

richvdh left a comment

lgtm

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 22, 2019

Codecov Report

Merging #4715 into develop will decrease coverage by <.01%.
The diff coverage is 75%.

@@             Coverage Diff             @@
##           develop    #4715      +/-   ##
===========================================
- Coverage    75.14%   75.14%   -0.01%     
===========================================
  Files          340      340              
  Lines        34815    34817       +2     
  Branches      5702     5702              
===========================================
+ Hits         26162    26163       +1     
- Misses        7044     7047       +3     
+ Partials      1609     1607       -2

@erikjohnston erikjohnston merged commit 9982c71 into develop Feb 22, 2019

7 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 75% of diff hit (target 0%)
Details
codecov/project 75.14% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@erikjohnston erikjohnston deleted the erikj/fix_state_invalidation branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.