Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ACME config for python 2. #4717

Merged
merged 1 commit into from Feb 25, 2019

Conversation

Projects
None yet
4 participants
@richvdh
Copy link
Member

richvdh commented Feb 22, 2019

Fixes #4675.

@richvdh richvdh requested a review from matrix-org/synapse-core Feb 22, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 22, 2019

Codecov Report

Merging #4717 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4717      +/-   ##
===========================================
+ Coverage    75.15%   75.16%   +<.01%     
===========================================
  Files          340      340              
  Lines        34823    34824       +1     
  Branches      5704     5704              
===========================================
+ Hits         26171    26174       +3     
+ Misses        7042     7039       -3     
- Partials      1610     1611       +1

@hawkowl hawkowl merged commit 641c409 into develop Feb 25, 2019

7 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 75.16% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hawkowl hawkowl deleted the rav/fix_acme_py2_again branch Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.