Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors when fetching remote server keys #4722

Merged
merged 3 commits into from Feb 25, 2019

Conversation

Projects
None yet
3 participants
@erikjohnston
Copy link
Member

erikjohnston commented Feb 23, 2019

No description provided.

erikjohnston added some commits Feb 23, 2019

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Feb 23, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 23, 2019

Codecov Report

Merging #4722 into develop will decrease coverage by 0.01%.
The diff coverage is 38.88%.

@@             Coverage Diff             @@
##           develop    #4722      +/-   ##
===========================================
- Coverage    75.15%   75.14%   -0.02%     
===========================================
  Files          340      340              
  Lines        34823    34840      +17     
  Branches      5704     5707       +3     
===========================================
+ Hits         26171    26179       +8     
- Misses        7042     7050       +8     
- Partials      1610     1611       +1
long_retries=True,
)
except (NotRetryingDestination, RequestSendFailed) as e:
raise raise_from(

This comment has been minimized.

@richvdh

richvdh Feb 25, 2019

Member

I think the raise is redundant here?

This comment has been minimized.

@erikjohnston

erikjohnston Feb 25, 2019

Author Member

Aha, yes

@richvdh
Copy link
Member

richvdh left a comment

lgtm

@erikjohnston erikjohnston merged commit 16c7afa into develop Feb 25, 2019

7 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 38.88% of diff hit (target 0%)
Details
codecov/project 75.14% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@erikjohnston erikjohnston deleted the erikj/correctly_handle_keyring_exceptions branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.