Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log tracebacks correctly #4737

Merged
merged 2 commits into from Feb 25, 2019

Conversation

Projects
None yet
2 participants
@erikjohnston
Copy link
Member

commented Feb 25, 2019

No description provided.

erikjohnston added some commits Feb 25, 2019

@erikjohnston erikjohnston marked this pull request as ready for review Feb 25, 2019

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Feb 25, 2019

@erikjohnston

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2019

Actually, do we even want to be using Failure.getTraceback() in a python 3 world?

@richvdh

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

Actually, do we even want to be using Failure.getTraceback() in a python 3 world?

Yes, IME.

@richvdh
Copy link
Member

left a comment

lgtm

@erikjohnston erikjohnston merged commit 65f3fbf into develop Feb 25, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@erikjohnston erikjohnston deleted the erikj/failure_log_tb branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.