Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Don't log stack trace when client has gone away during media download #4738

Merged
merged 3 commits into from Feb 25, 2019
Merged

Don't log stack trace when client has gone away during media download #4738

merged 3 commits into from Feb 25, 2019

Conversation

erikjohnston
Copy link
Member

No description provided.

@erikjohnston erikjohnston requested a review from a team February 25, 2019 17:26
@erikjohnston erikjohnston marked this pull request as ready for review February 25, 2019 17:26
richvdh
richvdh approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

fixes 4661 ?

changelog.d/4738.misc Outdated
@@ -0,0 +1 @@
Cleanup request exception logging
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full-stop?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nyargh

@erikjohnston
Copy link
Member Author

Fixes #4661

@hawkowl hawkowl merged commit 899a119 into develop Feb 25, 2019
@hawkowl hawkowl deleted the erikj/media_repo_err branch February 25, 2019 19:17
@richvdh richvdh mentioned this pull request Feb 26, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erikjohnston @richvdh @hawkowl