Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log stack trace when client has gone away during media download #4738

Merged
merged 3 commits into from Feb 25, 2019

Conversation

Projects
None yet
3 participants
@erikjohnston
Copy link
Member

erikjohnston commented Feb 25, 2019

No description provided.

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Feb 25, 2019

@erikjohnston erikjohnston marked this pull request as ready for review Feb 25, 2019

@richvdh
Copy link
Member

richvdh left a comment

lgtm.

fixes 4661 ?

@@ -0,0 +1 @@
Cleanup request exception logging

This comment has been minimized.

Copy link
@richvdh

richvdh Feb 25, 2019

Member

full-stop?

This comment has been minimized.

Copy link
@erikjohnston

erikjohnston Feb 25, 2019

Author Member

nyargh

@erikjohnston

This comment has been minimized.

Copy link
Member Author

erikjohnston commented Feb 25, 2019

Fixes #4661

@hawkowl hawkowl merged commit 899a119 into develop Feb 25, 2019

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details

@hawkowl hawkowl deleted the erikj/media_repo_err branch Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.