Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors to replication stream row update/parsing #4954

Merged
merged 4 commits into from Mar 28, 2019

Conversation

Projects
None yet
2 participants
@richvdh
Copy link
Member

commented Mar 27, 2019

  1. Skip building a ROW_TYPE when building updates: we're about to turn it straight into a JSON object anyway so building a ROW_TYPE is a bit pointless, and reduces flexibility in the update_function.

  2. Add parse_row method to replication stream class: This will allow individual stream classes to override how a row is parsed.

Builds on #4953.

richvdh added some commits Mar 27, 2019

Add parse_row method to replication stream class
This will allow individual stream classes to override how a row is parsed.
Skip building a ROW_TYPE when building updates
We're about to turn it straight into a JSON object anyway so building a
ROW_TYPE is a bit pointless, and reduces flexibility in the update_function.

@richvdh richvdh requested a review from matrix-org/synapse-core Mar 27, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 27, 2019

Codecov Report

Merging #4954 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4954      +/-   ##
===========================================
+ Coverage    60.44%   60.44%   +<.01%     
===========================================
  Files          331      331              
  Lines        34100    34102       +2     
  Branches      5627     5627              
===========================================
+ Hits         20612    20614       +2     
  Misses       12017    12017              
  Partials      1471     1471

@richvdh richvdh merged commit d688a51 into develop Mar 28, 2019

24 checks passed

buildkite/synapse Build #662 passed (17 minutes, 58 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 5 seconds)
Details
buildkite/synapse/isort Passed (15 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (12 seconds)
Details
buildkite/synapse/packaging Passed (15 seconds)
Details
buildkite/synapse/pep-8 Passed (49 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (10 minutes, 31 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (10 minutes, 57 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (5 minutes, 57 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (8 minutes, 11 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (11 minutes, 21 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 15 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 51 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 50 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (11 minutes, 38 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (10 minutes, 51 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 12 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 60.44% (target 0%)
Details

@richvdh richvdh deleted the rav/refactor_parse_row branch Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.