Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run `black` on some storage modules that the stats branch touches #4959

Merged
merged 4 commits into from Mar 28, 2019

Conversation

Projects
None yet
2 participants
@hawkowl
Copy link
Contributor

commented Mar 28, 2019

No description provided.

@hawkowl hawkowl requested a review from matrix-org/synapse-core Mar 28, 2019

hawkowl added some commits Mar 28, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 28, 2019

Codecov Report

Merging #4959 into develop will increase coverage by <.01%.
The diff coverage is 73.97%.

@@             Coverage Diff             @@
##           develop    #4959      +/-   ##
===========================================
+ Coverage    60.43%   60.43%   +<.01%     
===========================================
  Files          328      328              
  Lines        34093    34094       +1     
  Branches      5627     5627              
===========================================
+ Hits         20605    20606       +1     
  Misses       12017    12017              
  Partials      1471     1471
@richvdh
Copy link
Member

left a comment

lgtm otherwise

@@ -30,7 +30,6 @@
import synapse.metrics
from synapse.api.constants import EventTypes
from synapse.api.errors import SynapseError
# these are only included to make the type annotations work

This comment has been minimized.

Copy link
@richvdh

richvdh Mar 28, 2019

Member

can we keep this?

@hawkowl hawkowl merged commit 2e06077 into develop Mar 28, 2019

24 checks passed

buildkite/synapse Build #657 passed (18 minutes, 29 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 21 seconds)
Details
buildkite/synapse/isort Passed (17 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (50 seconds)
Details
buildkite/synapse/packaging Passed (17 seconds)
Details
buildkite/synapse/pep-8 Passed (55 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 37 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 34 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 7 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (8 minutes, 21 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 13 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 54 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 44 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 10 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 11 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 33 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 73.97% of diff hit (target 0%)
Details
codecov/project 60.43% (target 0%)
Details

@hawkowl hawkowl deleted the hawkowl/black-storage branch Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.