Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect room-version variations into one place #4969

Merged
merged 1 commit into from Apr 1, 2019

Conversation

2 participants
@richvdh
Copy link
Member

commented Mar 29, 2019

Collect all the things that make room-versions different to one another into
one place, so that it's easier to define new room versions.

Sorry about the size of this PR :/

Collect room-version variations into one place
Collect all the things that make room-versions different to one another into
one place, so that it's easier to define new room versions.

@richvdh richvdh requested a review from matrix-org/synapse-core Mar 29, 2019

@erikjohnston
Copy link
Member

left a comment

Seems legit.

@codecov

This comment has been minimized.

Copy link

commented Mar 29, 2019

Codecov Report

Merging #4969 into develop will increase coverage by 0.03%.
The diff coverage is 79.22%.

@@             Coverage Diff             @@
##           develop    #4969      +/-   ##
===========================================
+ Coverage    60.57%   60.61%   +0.03%     
===========================================
  Files          331      332       +1     
  Lines        34213    34235      +22     
  Branches      5655     5655              
===========================================
+ Hits         20723    20750      +27     
+ Misses       12012    12011       -1     
+ Partials      1478     1474       -4

@richvdh richvdh merged commit 54a87a7 into develop Apr 1, 2019

24 checks passed

buildkite/synapse Build #683 passed (17 minutes, 14 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 8 seconds)
Details
buildkite/synapse/isort Passed (15 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (48 seconds)
Details
buildkite/synapse/packaging Passed (17 seconds)
Details
buildkite/synapse/pep-8 Passed (51 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 47 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 41 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 8 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (8 minutes, 2 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 8 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 14 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 51 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 11 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 23 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 31 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 16 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 79.22% of diff hit (target 0%)
Details
codecov/project 60.61% (target 0%)
Details

@richvdh richvdh added this to In progress in Homeserver Task Board via automation Apr 4, 2019

@richvdh richvdh moved this from In progress to Done in Homeserver Task Board Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.