Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start.sh: Fix the --no-rate-limit option for messages #4981

Merged
merged 1 commit into from Apr 1, 2019

Conversation

Projects
None yet
2 participants
@manuroe
Copy link
Contributor

commented Apr 1, 2019

and make it bypass rate limit on registration and login too

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file
  • Pull request includes a sign off

@manuroe manuroe force-pushed the manuroe/demo_bypass_account_rate_limiting branch from 953900a to 23e1eb7 Apr 1, 2019

start.sh: Fix the --no-rate-limit option for messages and make it byp…
…ass rate limit on registration and login too.

@manuroe manuroe force-pushed the manuroe/demo_bypass_account_rate_limiting branch from 23e1eb7 to bb925b1 Apr 1, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 1, 2019

Codecov Report

Merging #4981 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4981   +/-   ##
========================================
  Coverage    60.61%   60.61%           
========================================
  Files          332      332           
  Lines        34235    34235           
  Branches      5655     5655           
========================================
  Hits         20750    20750           
  Misses       12011    12011           
  Partials      1474     1474
@babolivier
Copy link
Member

left a comment

lgtm

@manuroe manuroe merged commit d461c65 into develop Apr 1, 2019

24 checks passed

buildkite/synapse Build #703 passed (13 minutes, 26 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 5 seconds)
Details
buildkite/synapse/isort Passed (15 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (17 seconds)
Details
buildkite/synapse/packaging Passed (17 seconds)
Details
buildkite/synapse/pep-8 Passed (49 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 53 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 52 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 21 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (7 minutes, 49 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 28 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 28 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 58 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 9 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (11 minutes, 47 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 21 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 56 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 54a87a7...bb925b1
Details
codecov/project 60.61% (target 0%)
Details

@manuroe manuroe deleted the manuroe/demo_bypass_account_rate_limiting branch Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.