Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct default POSTGRES_USER in Docker README #4987

Merged

Conversation

3 participants
@f35f0ef9d0e827dae86552d3899f78fc
Copy link
Contributor

commented Apr 2, 2019

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file
  • Pull request includes a sign off

f35f0ef9d0e827dae86552d3899f78fc added some commits Apr 2, 2019

@f35f0ef9d0e827dae86552d3899f78fc

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

@f35f0ef9d0e827dae86552d3899f78fc f35f0ef9d0e827dae86552d3899f78fc changed the title Correct default POSTGRES_USER Correct default POSTGRES_USER in Docker README Apr 2, 2019

@f35f0ef9d0e827dae86552d3899f78fc f35f0ef9d0e827dae86552d3899f78fc marked this pull request as ready for review Apr 2, 2019

@f35f0ef9d0e827dae86552d3899f78fc

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

This is where the default user is defined:

user: "{{ POSTGRES_USER or "synapse" }}"

@codecov

This comment has been minimized.

Copy link

commented Apr 3, 2019

Codecov Report

Merging #4987 into develop will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4987      +/-   ##
===========================================
- Coverage     60.6%   60.57%   -0.04%     
===========================================
  Files          332      331       -1     
  Lines        34235    34213      -22     
  Branches      5655     5655              
===========================================
- Hits         20749    20725      -24     
- Misses       12011    12013       +2     
  Partials      1475     1475
@richvdh
Copy link
Member

left a comment

As CONTRIBUTING.rst says, I'm afraid we cannot accept contributions without signoff from a legally-identifiable name.

Show resolved Hide resolved docker/conf/homeserver.yaml Outdated

@richvdh richvdh added this to In progress in Homeserver Task Board via automation Apr 3, 2019

f35f0ef9d0e827dae86552d3899f78fc added some commits Apr 4, 2019

Revert "Updated changelog"
This reverts commit ccaa32c.
Revert "Fixing #4663"
This reverts commit ceeae4d.
Revert "Merge pull request #1 from f35f0ef9d0e827dae86552d3899f78fc/f…
…ix4663"

This reverts commit 800f740, reversing
changes made to 10fd0af.

@richvdh richvdh requested a review from matrix-org/synapse-core Apr 4, 2019

@erikjohnston

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

Thanks for this!

@erikjohnston erikjohnston merged commit 40810b8 into matrix-org:develop Apr 4, 2019

24 checks passed

buildkite/synapse Build #826 passed (13 minutes, 39 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 3 seconds)
Details
buildkite/synapse/isort Passed (16 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (14 seconds)
Details
buildkite/synapse/packaging Passed (21 seconds)
Details
buildkite/synapse/pep-8 Passed (50 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 14 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 11 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 17 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (7 minutes, 48 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (11 minutes, 59 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (11 minutes, 46 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 53 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 26 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 26 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 33 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 38 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 4c552ed...f26b889
Details
codecov/project 60.57% (target 0%)
Details

Homeserver Task Board automation moved this from In progress to Done Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.