Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove presence lists #4989

Merged
merged 13 commits into from Apr 3, 2019

Conversation

Projects
None yet
2 participants
@neilisfragile
Copy link
Contributor

commented Apr 2, 2019

PRing as a convenient way to test against sytest.
Have commented rather deleted code as a convenience in case I need to back out changes.
Will delete properly when I put it up for review.
Todo - remove presence_list from db

@neilisfragile neilisfragile changed the title first draft of remove presence lists WIP remove presence lists Apr 2, 2019

neilisfragile added some commits Apr 2, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 2, 2019

Codecov Report

Merging #4989 into develop will increase coverage by 0.07%.
The diff coverage is 75%.

@@             Coverage Diff             @@
##           develop    #4989      +/-   ##
===========================================
+ Coverage    60.63%   60.71%   +0.07%     
===========================================
  Files          332      332              
  Lines        34255    34146     -109     
  Branches      5658     5629      -29     
===========================================
- Hits         20772    20731      -41     
+ Misses       12005    11945      -60     
+ Partials      1478     1470       -8

neilisfragile added some commits Apr 2, 2019

@neilisfragile neilisfragile requested a review from matrix-org/synapse-core Apr 2, 2019

@neilisfragile neilisfragile changed the title WIP remove presence lists Remove presence lists Apr 2, 2019

@neilisfragile

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

I have not removed the db table, am thinking it would be safer to do so in a subsequent release - wdyt?

Show resolved Hide resolved changelog.d/4989.misc Outdated
@richvdh
Copy link
Member

left a comment

can you remove the table from the original schema files?

Suggest including a comment along the lines of "we used to create a table called X, but this is no longer used and is removed in delta Y"

neilisfragile added some commits Apr 2, 2019

@neilisfragile neilisfragile requested a review from richvdh Apr 2, 2019

@richvdh

richvdh approved these changes Apr 2, 2019

Copy link
Member

left a comment

lgtm

@neilisfragile neilisfragile merged commit e841955 into develop Apr 3, 2019

24 checks passed

buildkite/synapse Build #785 passed (18 minutes, 52 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 3 seconds)
Details
buildkite/synapse/isort Passed (15 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (12 seconds)
Details
buildkite/synapse/packaging Passed (16 seconds)
Details
buildkite/synapse/pep-8 Passed (50 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 11 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 9 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 36 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (8 minutes, 9 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 8 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (11 minutes, 56 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 31 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 27 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 28 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 26 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 20 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 75% of diff hit (target 0%)
Details
codecov/project 60.71% (target 0%)
Details

@neilisfragile neilisfragile deleted the neilj/remove_presence_lists branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.