Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer related groups on room upgrade #4990

Merged
merged 2 commits into from Apr 2, 2019

Conversation

Projects
None yet
2 participants
@anoadragon453
Copy link
Member

commented Apr 2, 2019

Transfers the m.room.related_groups state event on room upgrade.

Sytest PR: matrix-org/sytest#596

Closes #4633

anoadragon453 added some commits Apr 2, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 2, 2019

Codecov Report

Merging #4990 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4990      +/-   ##
===========================================
+ Coverage    60.64%   60.64%   +<.01%     
===========================================
  Files          332      332              
  Lines        34241    34242       +1     
  Branches      5657     5657              
===========================================
+ Hits         20765    20766       +1     
+ Misses       12003    12000       -3     
- Partials      1473     1476       +3

@anoadragon453 anoadragon453 marked this pull request as ready for review Apr 2, 2019

@anoadragon453 anoadragon453 requested a review from matrix-org/synapse-core Apr 2, 2019

@richvdh

richvdh approved these changes Apr 2, 2019

Copy link
Member

left a comment

looks plausible

@anoadragon453 anoadragon453 merged commit 66e7870 into develop Apr 2, 2019

24 checks passed

buildkite/synapse Build #756 passed (25 minutes, 8 seconds)
Details
buildkite/synapse/check-sample-config Passed (4 minutes, 32 seconds)
Details
buildkite/synapse/isort Passed (15 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (13 seconds)
Details
buildkite/synapse/packaging Passed (26 seconds)
Details
buildkite/synapse/pep-8 Passed (1 minute, 53 seconds)
Details
buildkite/synapse/pipeline Passed (5 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 46 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 4 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (22 minutes, 59 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (9 minutes, 25 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 36 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 47 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 18 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 1 second)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 45 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 31 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 5 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 60.64% (target 0%)
Details

anoadragon453 added a commit to matrix-org/sytest that referenced this pull request Apr 2, 2019

@anoadragon453 anoadragon453 deleted the anoa/related_groups_room_upgrade branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.