Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop tables listed in #1830 #4992

Merged
merged 28 commits into from Apr 8, 2019

Conversation

Projects
None yet
2 participants
@neilisfragile
Copy link
Contributor

commented Apr 2, 2019

neilisfragile added some commits Apr 2, 2019

.

@neilisfragile neilisfragile requested a review from matrix-org/synapse-core Apr 2, 2019

@neilisfragile

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

CI will fix itself on matrix-org/sytest#598 getting merged

@richvdh
Copy link
Member

left a comment

seems to be based on another pr? hard to review until it's merged

@codecov

This comment has been minimized.

Copy link

commented Apr 2, 2019

Codecov Report

Merging #4992 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #4992   +/-   ##
=======================================
  Coverage     60.7%   60.7%           
=======================================
  Files          332     332           
  Lines        34172   34172           
  Branches      5633    5633           
=======================================
  Hits         20743   20743           
+ Misses       11958   11955    -3     
- Partials      1471    1474    +3

neilisfragile added some commits Apr 3, 2019

@richvdh

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

move to delta 55

I'd prefer it if we didn't bump the schema version number for every single change.

neilisfragile added some commits Apr 3, 2019

@neilisfragile

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

Have not covered room_names and topic as referenced in #1830 (comment) because I want to see #4338 land first

@neilisfragile neilisfragile requested a review from richvdh Apr 4, 2019

@richvdh

richvdh approved these changes Apr 4, 2019

Copy link
Member

left a comment

lgtm otherwise

regex TEXT,
FOREIGN KEY(as_id) REFERENCES application_services(id)
);
/* We used to create a tables called application_services and

This comment has been minimized.

Copy link
@richvdh

richvdh Apr 4, 2019

Member
Suggested change
/* We used to create a tables called application_services and
/* We used to create tables called application_services and

This comment has been minimized.

Copy link
@richvdh

richvdh Apr 4, 2019

Member

likewise in a number of other places

@richvdh

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

btw please remember to squash-merge this. we definitely don't want all 24 commits in the repo history.

@richvdh

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

(as per #synapse-dev, we could kill full_schemas/11 altogether)

@neilisfragile neilisfragile requested a review from richvdh Apr 8, 2019

neilisfragile added some commits Apr 8, 2019

@richvdh

richvdh approved these changes Apr 8, 2019

Copy link
Member

left a comment

lgtm. please please remember to squash-merge.

@neilisfragile neilisfragile merged commit 2d95168 into develop Apr 8, 2019

22 checks passed

buildkite/synapse Build #878 passed (13 minutes, 30 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 11 seconds)
Details
buildkite/synapse/isort Passed (19 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (16 seconds)
Details
buildkite/synapse/packaging Passed (16 seconds)
Details
buildkite/synapse/pep-8 Passed (50 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 28 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 44 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 23 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (7 minutes, 44 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 31 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 2 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 19 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 3 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (11 minutes, 59 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 2 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 55 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details

erikjohnston added a commit that referenced this pull request Apr 9, 2019

Fix schema upgrade when dropping tables
We need to drop tables in the correct order due to foreign table
constraints (on `application_services`), otherwise the DROP TABLE
command will fail.

Introduced in #4992.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.