This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
drop tables listed in #1830 #4992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI will fix itself on matrix-org/sytest#598 getting merged |
richvdh
suggested changes
Apr 2, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4992 +/- ##
=======================================
Coverage 60.7% 60.7%
=======================================
Files 332 332
Lines 34172 34172
Branches 5633 5633
=======================================
Hits 20743 20743
+ Misses 11958 11955 -3
- Partials 1471 1474 +3 |
I'd prefer it if we didn't bump the schema version number for every single change. |
|
Have not covered |
richvdh
approved these changes
Apr 4, 2019
| regex TEXT, | ||
| FOREIGN KEY(as_id) REFERENCES application_services(id) | ||
| ); | ||
| /* We used to create a tables called application_services and |
There was a problem hiding this comment.
Suggested change
| /* We used to create a tables called application_services and | |
| /* We used to create tables called application_services and |
There was a problem hiding this comment.
likewise in a number of other places
|
btw please remember to squash-merge this. we definitely don't want all 24 commits in the repo history. |
|
(as per #synapse-dev, we could kill |
This reverts commit 74e809a.
richvdh
approved these changes
Apr 8, 2019
erikjohnston
added a commit
that referenced
this pull request
Apr 9, 2019
We need to drop tables in the correct order due to foreign table constraints (on `application_services`), otherwise the DROP TABLE command will fail. Introduced in #4992.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1830