Conversation
CI will fix itself on matrix-org/sytest#598 getting merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to be based on another pr? hard to review until it's merged
Codecov Report
@@ Coverage Diff @@
## develop #4992 +/- ##
=======================================
Coverage 60.7% 60.7%
=======================================
Files 332 332
Lines 34172 34172
Branches 5633 5633
=======================================
Hits 20743 20743
+ Misses 11958 11955 -3
- Partials 1471 1474 +3 |
I'd prefer it if we didn't bump the schema version number for every single change. |
Have not covered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm otherwise
regex TEXT, | ||
FOREIGN KEY(as_id) REFERENCES application_services(id) | ||
); | ||
/* We used to create a tables called application_services and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/* We used to create a tables called application_services and | |
/* We used to create tables called application_services and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
likewise in a number of other places
btw please remember to squash-merge this. we definitely don't want all 24 commits in the repo history. |
(as per #synapse-dev, we could kill |
This reverts commit 74e809a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. please please remember to squash-merge.
We need to drop tables in the correct order due to foreign table constraints (on `application_services`), otherwise the DROP TABLE command will fail. Introduced in #4992.
#1830