Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run black on the rest of the storage module #4996

Merged
merged 2 commits into from Apr 3, 2019

Conversation

Projects
None yet
2 participants
@hawkowl
Copy link
Contributor

commented Apr 3, 2019

No description provided.

@hawkowl hawkowl requested a review from matrix-org/synapse-core Apr 3, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 3, 2019

Codecov Report

Merging #4996 into develop will not change coverage.
The diff coverage is 70.58%.

@@           Coverage Diff            @@
##           develop    #4996   +/-   ##
========================================
  Coverage    60.63%   60.63%           
========================================
  Files          332      332           
  Lines        34255    34255           
  Branches      5658     5658           
========================================
  Hits         20772    20772           
  Misses       12008    12008           
  Partials      1475     1475
@richvdh

richvdh approved these changes Apr 3, 2019

Copy link
Member

left a comment

what's the worst that can happen

@richvdh richvdh merged commit 7efd1d8 into develop Apr 3, 2019

24 checks passed

buildkite/synapse Build #781 passed (21 minutes, 52 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 11 seconds)
Details
buildkite/synapse/isort Passed (17 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (13 seconds)
Details
buildkite/synapse/packaging Passed (18 seconds)
Details
buildkite/synapse/pep-8 Passed (57 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 55 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 46 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (7 minutes, 15 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (8 minutes, 3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 31 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 36 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (8 minutes, 7 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 16 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 15 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 30 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 50 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 70.58% of diff hit (target 0%)
Details
codecov/project 60.63% (target 0%)
Details

@hawkowl hawkowl deleted the hawkowl/black-storage-all branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.