Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar and document get_current_users_in_room #4998

Merged
merged 3 commits into from Apr 3, 2019

Conversation

Projects
None yet
2 participants
@anoadragon453
Copy link
Member

commented Apr 3, 2019

Fix grammar of get_current_users_in_room and give it a docstring.

@anoadragon453 anoadragon453 requested a review from matrix-org/synapse-core Apr 3, 2019

@erikjohnston
Copy link
Member

left a comment

Looks good assuming CI passes

@anoadragon453

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

Oh yeah, newsfile.

@codecov

This comment has been minimized.

Copy link

commented Apr 3, 2019

Codecov Report

Merging #4998 into develop will not change coverage.
The diff coverage is 61.11%.

@@           Coverage Diff           @@
##           develop   #4998   +/-   ##
=======================================
  Coverage     60.7%   60.7%           
=======================================
  Files          332     332           
  Lines        34172   34172           
  Branches      5633    5633           
=======================================
  Hits         20743   20743           
  Misses       11958   11958           
  Partials      1471    1471

@anoadragon453 anoadragon453 merged commit 4a4d5c4 into develop Apr 3, 2019

24 checks passed

buildkite/synapse Build #800 passed (16 minutes, 9 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 6 seconds)
Details
buildkite/synapse/isort Passed (15 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (13 seconds)
Details
buildkite/synapse/packaging Passed (16 seconds)
Details
buildkite/synapse/pep-8 Passed (52 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 28 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 24 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 21 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (7 minutes, 59 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 6 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 34 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 9 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 12 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 27 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 27 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 1 second)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 61.11% of diff hit (target 0%)
Details
codecov/project 60.7% (target 0%)
Details

@anoadragon453 anoadragon453 deleted the anoa/fix_grammar branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.