Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete group admin API #5002

Merged
merged 4 commits into from Apr 4, 2019

Conversation

2 participants
@erikjohnston
Copy link
Member

commented Apr 3, 2019

We can probably easily extend this to making a proper /delete_group API for group admins later.

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Apr 3, 2019

@erikjohnston erikjohnston added this to In progress in Homeserver Task Board via automation Apr 4, 2019

@richvdh

richvdh approved these changes Apr 4, 2019

Copy link
Member

left a comment

lgtm

class DeleteGroupAdminRestServlet(ClientV1RestServlet):
"""Allows deleting of local groups
"""
PATTERNS = client_path_patterns("/admin/delete_group/(?P<group_id>[^/]*)")

This comment has been minimized.

Copy link
@richvdh

richvdh Apr 4, 2019

Member

given #4850, it would be good to consider putting this elsewhere.

OTOH there's something to be said for first adding an alternative path for all the existing admin APIs, and only then start adding new ones on the new path.

This comment has been minimized.

Copy link
@erikjohnston

erikjohnston Apr 4, 2019

Author Member

Point. Though I don't really know what exactly we want to do there

@erikjohnston erikjohnston merged commit 616e6a1 into develop Apr 4, 2019

22 checks passed

buildkite/synapse Build #810 passed (14 minutes, 45 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 5 seconds)
Details
buildkite/synapse/isort Passed (16 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (48 seconds)
Details
buildkite/synapse/packaging Passed (16 seconds)
Details
buildkite/synapse/pep-8 Passed (52 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 23 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 4 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 12 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (8 minutes, 13 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 9 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 24 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 25 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 22 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 9 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 25 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details

Homeserver Task Board automation moved this from In progress to Done Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.