Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to block users from looking up 3PIDs #5010

Merged
merged 7 commits into from Apr 4, 2019

Conversation

Projects
None yet
2 participants
@babolivier
Copy link
Member

commented Apr 4, 2019

Not sure this config option belongs to register.py since it has nothing to do with registration, however there's no identity.py file and all of the IS settings are there, so I figured I'd put that in there as well.

@babolivier babolivier requested review from matrix-org/synapse-core and removed request for matrix-org/synapse-core Apr 4, 2019

@babolivier

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

Hmm, I meant to add some tests, but I'm not sure how to test that...

@babolivier babolivier requested a review from matrix-org/synapse-core Apr 4, 2019

@erikjohnston

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

Hmm, I meant to add some tests, but I'm not sure how to test that...

It's actually not too bad to do a quick test, can IRL

@codecov

This comment has been minimized.

Copy link

commented Apr 4, 2019

Codecov Report

Merging #5010 into develop will decrease coverage by 1.03%.
The diff coverage is 75%.

@@             Coverage Diff             @@
##           develop    #5010      +/-   ##
===========================================
- Coverage    61.49%   60.45%   -1.04%     
===========================================
  Files          332      328       -4     
  Lines        34223    34097     -126     
  Branches      5645     5628      -17     
===========================================
- Hits         21046    20615     -431     
- Misses       11669    12009     +340     
+ Partials      1508     1473      -35

@babolivier babolivier force-pushed the babolivier/dont-lookup-3pid branch from a2fc505 to 517f169 Apr 4, 2019

babolivier added some commits Apr 4, 2019

@erikjohnston

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

FTR: This doesn't stop clients from talking directly to the identity server to do lookups.

@erikjohnston

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

@babolivier: We will also want to merge this into dinsic branch

@babolivier babolivier merged commit 8e85493 into develop Apr 4, 2019

24 checks passed

buildkite/synapse Build #859 passed (23 minutes, 29 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 14 seconds)
Details
buildkite/synapse/isort Passed (16 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (15 seconds)
Details
buildkite/synapse/packaging Passed (16 seconds)
Details
buildkite/synapse/pep-8 Passed (54 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 4 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (10 minutes, 46 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 20 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (7 minutes, 45 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (11 minutes, 46 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 4 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 19 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (22 minutes, 27 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (11 minutes, 38 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 51 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 26 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 75% of diff hit (target 0%)
Details
codecov/project 60.45% (target 0%)
Details

erikjohnston added a commit that referenced this pull request Apr 5, 2019

@anoadragon453 anoadragon453 deleted the babolivier/dont-lookup-3pid branch Apr 11, 2019

@anoadragon453 anoadragon453 restored the babolivier/dont-lookup-3pid branch Apr 11, 2019

@babolivier babolivier referenced this pull request Apr 16, 2019

Merged

[DINSIC] Add ability to proxy identity lookups #5048

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.