Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add context to phonehome stats #5020

Merged
merged 2 commits into from Apr 8, 2019

Conversation

Projects
None yet
2 participants
@neilisfragile
Copy link
Contributor

commented Apr 6, 2019

No description provided.

neilisfragile added some commits Apr 6, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 7, 2019

Codecov Report

Merging #5020 into develop will decrease coverage by <.01%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           develop    #5020      +/-   ##
===========================================
- Coverage    61.51%   61.51%   -0.01%     
===========================================
  Files          332      332              
  Lines        34227    34229       +2     
  Branches      5646     5646              
===========================================
- Hits         21056    21055       -1     
- Misses       11661    11664       +3     
  Partials      1510     1510
1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Apr 7, 2019

Codecov Report

Merging #5020 into develop will decrease coverage by <.01%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           develop    #5020      +/-   ##
===========================================
- Coverage    61.51%   61.51%   -0.01%     
===========================================
  Files          332      332              
  Lines        34227    34229       +2     
  Branches      5646     5646              
===========================================
- Hits         21056    21055       -1     
- Misses       11661    11664       +3     
  Partials      1510     1510

@neilisfragile neilisfragile marked this pull request as ready for review Apr 8, 2019

@neilisfragile neilisfragile requested a review from matrix-org/synapse-core Apr 8, 2019

@babolivier
Copy link
Member

left a comment

lgtm

@neilisfragile neilisfragile merged commit b25e387 into develop Apr 8, 2019

24 checks passed

buildkite/synapse Build #872 passed (23 minutes, 15 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 18 seconds)
Details
buildkite/synapse/isort Passed (19 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (15 seconds)
Details
buildkite/synapse/packaging Passed (18 seconds)
Details
buildkite/synapse/pep-8 Passed (1 minute, 1 second)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (12 minutes, 3 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 4 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (8 minutes, 17 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (8 minutes, 33 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 44 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (13 minutes, 30 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (8 minutes, 58 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (8 minutes, 1 second)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 23 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (13 minutes, 3 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 32 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 50% of diff hit (target 0%)
Details
codecov/project 61.51% (target 0%)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.