Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix from_server buglet in get_keys_from_perspectives #5024

Merged
merged 1 commit into from Apr 8, 2019

Conversation

2 participants
@richvdh
Copy link
Member

commented Apr 8, 2019

make sure we store the name of the server the keys came from, rather than the
origin server, after doing a fetch-from-perspectives.

Fix from_server buglet in get_keys_from_perspectives
make sure we store the name of the server the keys came from, rather than the
origin server, after doing a fetch-from-perspectives.

@richvdh richvdh requested a review from matrix-org/synapse-core Apr 8, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 8, 2019

Codecov Report

Merging #5024 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #5024   +/-   ##
========================================
  Coverage    61.59%   61.59%           
========================================
  Files          332      332           
  Lines        34225    34225           
  Branches      5643     5643           
========================================
  Hits         21081    21081           
  Misses       11630    11630           
  Partials      1514     1514
1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Apr 8, 2019

Codecov Report

Merging #5024 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #5024   +/-   ##
========================================
  Coverage    61.59%   61.59%           
========================================
  Files          332      332           
  Lines        34225    34225           
  Branches      5643     5643           
========================================
  Hits         21081    21081           
  Misses       11630    11630           
  Partials      1514     1514

@richvdh richvdh merged commit 67d7b44 into develop Apr 8, 2019

24 checks passed

buildkite/synapse Build #876 passed (19 minutes, 44 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 10 seconds)
Details
buildkite/synapse/isort Passed (49 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (47 seconds)
Details
buildkite/synapse/packaging Passed (17 seconds)
Details
buildkite/synapse/pep-8 Passed (1 minute, 19 seconds)
Details
buildkite/synapse/pipeline Passed (8 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (12 minutes, 8 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 45 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 15 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (7 minutes, 37 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 2 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 9 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 6 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 21 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 49 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 8 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 58 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 7fc1e17...7d2a0c8
Details
codecov/project 61.59% (target 0%)
Details

@richvdh richvdh deleted the rav/record_correct_server_in_serverkeys branch Apr 8, 2019

@richvdh richvdh added this to In progress in Homeserver Task Board via automation Apr 8, 2019

@richvdh richvdh moved this from In progress to Done in Homeserver Task Board Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.