Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused server_tls_certificates functions #5028

Merged
merged 1 commit into from Apr 8, 2019

Conversation

2 participants
@richvdh
Copy link
Member

commented Apr 8, 2019

These have been unused since #4120, and with the demise of perspectives, it is
unlikely that they will ever be used again.

Remove unused server_tls_certificates functions
These have been unused since #4120, and with the demise of perspectives, it is
unlikely that they will ever be used again.

@richvdh richvdh requested a review from matrix-org/synapse-core Apr 8, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 8, 2019

Codecov Report

Merging #5028 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #5028      +/-   ##
===========================================
+ Coverage    61.59%   61.59%   +<.01%     
===========================================
  Files          332      332              
  Lines        34227    34215      -12     
  Branches      5643     5643              
===========================================
- Hits         21082    21076       -6     
+ Misses       11631    11625       -6     
  Partials      1514     1514

@richvdh richvdh merged commit 3352baa into develop Apr 8, 2019

24 checks passed

buildkite/synapse Build #892 passed (13 minutes, 47 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 12 seconds)
Details
buildkite/synapse/isort Passed (17 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (14 seconds)
Details
buildkite/synapse/packaging Passed (16 seconds)
Details
buildkite/synapse/pep-8 Passed (52 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 33 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 31 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 48 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (8 minutes)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 26 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 12 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 8 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 22 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 42 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 12 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 4 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing b25e387...4a381ed
Details
codecov/project 61.59% (target 0%)
Details

@richvdh richvdh added this to In progress in Homeserver Task Board via automation Apr 8, 2019

@richvdh richvdh moved this from In progress to Done in Homeserver Task Board Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.