Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump psycopg requirement #5032

Merged
merged 1 commit into from Apr 9, 2019

Conversation

2 participants
@richvdh
Copy link
Member

commented Apr 9, 2019

We use execute_batch, which only arrived in psycopg 2.7.

@richvdh richvdh requested a review from matrix-org/synapse-core Apr 9, 2019

@richvdh richvdh force-pushed the rav/bump_psycopg branch from 77ba432 to c013b55 Apr 9, 2019

@richvdh richvdh added this to In progress in Homeserver Task Board via automation Apr 9, 2019

@erikjohnston

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

I guess this wasn't caught in CI because we test old deps only against sqlite...

@codecov

This comment has been minimized.

Copy link

commented Apr 9, 2019

Codecov Report

Merging #5032 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #5032      +/-   ##
===========================================
- Coverage    61.59%   61.59%   -0.01%     
===========================================
  Files          332      332              
  Lines        34215    34215              
  Branches      5643     5643              
===========================================
- Hits         21076    21074       -2     
- Misses       11625    11628       +3     
+ Partials      1514     1513       -1

@richvdh richvdh merged commit 4abf5aa into develop Apr 9, 2019

24 checks passed

buildkite/synapse Build #899 passed (21 minutes, 15 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 19 seconds)
Details
buildkite/synapse/isort Passed (16 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (13 seconds)
Details
buildkite/synapse/packaging Passed (17 seconds)
Details
buildkite/synapse/pep-8 Passed (57 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 57 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 59 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (7 minutes, 14 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (8 minutes, 12 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 49 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 42 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (8 minutes, 18 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 37 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 33 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 35 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 30 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 3352baa...c013b55
Details
codecov/project 61.59% (target 0%)
Details

Homeserver Task Board automation moved this from In progress to Done Apr 9, 2019

@richvdh richvdh deleted the rav/bump_psycopg branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.