Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema upgrade when dropping tables #5033

Merged
merged 2 commits into from Apr 10, 2019

Conversation

Projects
None yet
3 participants
@erikjohnston
Copy link
Member

commented Apr 9, 2019

We need to drop tables in the correct order due to foreign table
constraints (on application_services), otherwise the DROP TABLE
command will fail.

erikjohnston added some commits Apr 9, 2019

Fix schema upgrade when dropping tables
We need to drop tables in the correct order due to foreign table
constraints (on `application_services`), otherwise the DROP TABLE
command will fail.

Introduced in #4992.

@erikjohnston erikjohnston force-pushed the erikj/fix_schema_delta branch from e6683a5 to 5e45b55 Apr 9, 2019

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Apr 9, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 9, 2019

Codecov Report

Merging #5033 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #5033   +/-   ##
========================================
  Coverage    61.58%   61.58%           
========================================
  Files          332      332           
  Lines        34216    34216           
  Branches      5643     5643           
========================================
  Hits         21071    21071           
  Misses       11632    11632           
  Partials      1513     1513
@neilisfragile
Copy link
Contributor

left a comment

LGTM

@richvdh

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

fixes #5040

@erikjohnston erikjohnston merged commit e446921 into develop Apr 10, 2019

24 checks passed

buildkite/synapse Build #905 passed (13 minutes, 53 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 13 seconds)
Details
buildkite/synapse/isort Passed (16 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (15 seconds)
Details
buildkite/synapse/packaging Passed (20 seconds)
Details
buildkite/synapse/pep-8 Passed (51 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 16 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 27 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 53 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (7 minutes, 54 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 16 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 37 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 22 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (8 minutes, 24 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 42 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 41 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 8 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 644b866...5e45b55
Details
codecov/project 61.58% (target 0%)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.