Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disappearing exceptions in manhole. #5035

Merged
merged 1 commit into from Apr 10, 2019

Conversation

2 participants
@richvdh
Copy link
Member

commented Apr 9, 2019

Avoid sending syntax errors from the manhole to sentry.

Fixes #4768.

Fix disappearing exceptions in manhole.
Avoid sending syntax errors from the manhole to sentry.

@richvdh richvdh requested a review from matrix-org/synapse-core Apr 9, 2019

@richvdh richvdh added this to In progress in Homeserver Task Board via automation Apr 9, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 9, 2019

Codecov Report

Merging #5035 into develop will decrease coverage by 0.02%.
The diff coverage is 27.58%.

@@             Coverage Diff             @@
##           develop    #5035      +/-   ##
===========================================
- Coverage    61.58%   61.55%   -0.03%     
===========================================
  Files          332      332              
  Lines        34216    34244      +28     
  Branches      5643     5644       +1     
===========================================
+ Hits         21071    21078       +7     
- Misses       11632    11650      +18     
- Partials      1513     1516       +3
@erikjohnston

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

How was sentry intercepting this? I assume its not logging as sentry would just pass that on

@richvdh

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

https://github.com/python/cpython/blob/v3.6.8/Lib/code.py#L128 normally sends the exception to self.write, which writes it to the ssh channel, but if somebody has set the exception hook (as sentry does), then it assumes you want to send it there instead.

this patch just removes the check on the exception hook.

@richvdh richvdh merged commit 329688c into develop Apr 10, 2019

24 checks passed

buildkite/synapse Build #906 passed (14 minutes)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 10 seconds)
Details
buildkite/synapse/isort Passed (15 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (13 seconds)
Details
buildkite/synapse/packaging Passed (18 seconds)
Details
buildkite/synapse/pep-8 Passed (53 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 31 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 34 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (7 minutes, 21 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (9 minutes, 8 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 23 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 21 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 13 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 49 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 13 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 21 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 27.58% of diff hit (target 0%)
Details
codecov/project 61.55% (target 0%)
Details

Homeserver Task Board automation moved this from In progress to Done Apr 10, 2019

@richvdh richvdh deleted the rav/fix_sentry_errors branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.