Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit in flight DNS requests #5037

Merged
merged 2 commits into from May 8, 2019

Conversation

Projects
None yet
3 participants
@erikjohnston
Copy link
Member

commented Apr 9, 2019

This is to work around a bug in twisted where a large number of
concurrent DNS requests cause it to tight loop forever.

c.f. https://twistedmatrix.com/trac/ticket/9620#ticket

@erikjohnston erikjohnston force-pushed the erikj/limit_inflight_dns branch from 7f479bb to 58dff0e Apr 9, 2019

erikjohnston added some commits Apr 9, 2019

Limit in flight DNS requests
This is to work around a bug in twisted where a large number of
concurrent DNS requests cause it to tight loop forever.

c.f. https://twistedmatrix.com/trac/ticket/9620#ticket

@erikjohnston erikjohnston force-pushed the erikj/limit_inflight_dns branch from 58dff0e to 02491e0 Apr 9, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 9, 2019

Codecov Report

Merging #5037 into develop will decrease coverage by 0.01%.
The diff coverage is 41.93%.

@@             Coverage Diff             @@
##           develop    #5037      +/-   ##
===========================================
- Coverage     61.6%   61.58%   -0.02%     
===========================================
  Files          332      332              
  Lines        34237    34267      +30     
  Branches      5647     5647              
===========================================
+ Hits         21090    21102      +12     
- Misses       11633    11651      +18     
  Partials      1514     1514

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Apr 9, 2019

@richvdh
Copy link
Member

left a comment

looks plausible to me, though we should probably poll @hawkowl ?

@erikjohnston erikjohnston requested a review from hawkowl May 7, 2019

@hawkowl

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

It's probably fine(tm)? :)

@erikjohnston erikjohnston merged commit c8c069d into develop May 8, 2019

24 checks passed

buildkite/synapse Build #915 passed (14 minutes, 19 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 13 seconds)
Details
buildkite/synapse/isort Passed (31 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (14 seconds)
Details
buildkite/synapse/packaging Passed (33 seconds)
Details
buildkite/synapse/pep-8 Passed (1 minute, 16 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 41 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 43 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 42 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (8 minutes, 32 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 11 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 56 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 33 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 47 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 24 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 19 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 25 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 41.93% of diff hit (target 0%)
Details
codecov/project 61.58% (target 0%)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.