Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send out emails with links to extend an account's validity period #5047

Merged
merged 1 commit into from Apr 17, 2019

Conversation

Projects
None yet
3 participants
@babolivier
Copy link
Member

commented Apr 11, 2019

TODO:

  • Send mail to one user with a randomly-generated link
  • Loop over users who didn't get a mail yet and are expiring soon
  • Handle clicks on renewal link:
    • Push the expiration timestamp back
    • Invalidate the cache on get_expiration_ts_for_user

Follows #5027

@codecov

This comment has been minimized.

Copy link

commented Apr 11, 2019

Codecov Report

Merging #5047 into develop will decrease coverage by 1.47%.
The diff coverage is 38.46%.

@@             Coverage Diff             @@
##           develop    #5047      +/-   ##
===========================================
- Coverage    61.57%   60.09%   -1.48%     
===========================================
  Files          332      328       -4     
  Lines        34265    34132     -133     
  Branches      5648     5633      -15     
===========================================
- Hits         21097    20512     -585     
- Misses       11654    12161     +507     
+ Partials      1514     1459      -55
@codecov

This comment has been minimized.

Copy link

commented Apr 15, 2019

Codecov Report

Merging #5047 into develop will decrease coverage by 1.23%.
The diff coverage is 31.15%.

@@             Coverage Diff             @@
##           develop    #5047      +/-   ##
===========================================
- Coverage    61.57%   60.33%   -1.24%     
===========================================
  Files          332      330       -2     
  Lines        34265    34244      -21     
  Branches      5648     5640       -8     
===========================================
- Hits         21097    20660     -437     
- Misses       11654    12109     +455     
+ Partials      1514     1475      -39
@codecov-io

This comment has been minimized.

Copy link

commented Apr 15, 2019

Codecov Report

Merging #5047 into develop will decrease coverage by 1%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           develop    #5047      +/-   ##
===========================================
- Coverage    61.57%   60.56%   -1.01%     
===========================================
  Files          332      330       -2     
  Lines        34274    34271       -3     
  Branches      5652     5645       -7     
===========================================
- Hits         21103    20756     -347     
- Misses       11656    12036     +380     
+ Partials      1515     1479      -36

@babolivier babolivier marked this pull request as ready for review Apr 15, 2019

@babolivier babolivier requested a review from matrix-org/synapse-core Apr 15, 2019

@babolivier

This comment has been minimized.

Copy link
Member Author

commented Apr 15, 2019

Status ftr: Code is here and should be functional/reviewable, I'll add tests tomorrow.

The whole thing should be fairly well tested now.

@erikjohnston
Copy link
Member

left a comment

Just a few quibbles, but otherwise looks look good!

Show resolved Hide resolved synapse/config/registration.py Outdated
Show resolved Hide resolved synapse/storage/schema/delta/54/account_validity.sql
Show resolved Hide resolved synapse/rest/client/v2_alpha/account_validity.py Outdated

@babolivier babolivier requested a review from matrix-org/synapse-core Apr 17, 2019

@babolivier babolivier requested a review from matrix-org/synapse-core Apr 17, 2019

@babolivier babolivier force-pushed the babolivier/account_expiration branch from c954294 to 20f0617 Apr 17, 2019

@babolivier babolivier merged commit 9193402 into develop Apr 17, 2019

22 checks passed

buildkite/synapse Build #1046 passed (13 minutes, 40 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 22 seconds)
Details
buildkite/synapse/isort Passed (16 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (13 seconds)
Details
buildkite/synapse/packaging Passed (20 seconds)
Details
buildkite/synapse/pep-8 Passed (59 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 1 second)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (10 minutes, 56 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 20 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (8 minutes, 6 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 25 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 22 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 34 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 27 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (11 minutes, 43 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 14 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 9 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.