Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VersionRestServlet doesn't take a param #5065

Merged
merged 2 commits into from Apr 16, 2019

Conversation

Projects
None yet
2 participants
@erikjohnston
Copy link
Member

commented Apr 15, 2019

No description provided.

erikjohnston added some commits Apr 15, 2019

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Apr 15, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 15, 2019

Codecov Report

Merging #5065 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #5065   +/-   ##
========================================
  Coverage    61.56%   61.56%           
========================================
  Files          332      332           
  Lines        34270    34270           
  Branches      5650     5650           
========================================
  Hits         21097    21097           
- Misses       11656    11659    +3     
+ Partials      1517     1514    -3
@babolivier
Copy link
Member

left a comment

lgtm

@erikjohnston

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2019

Introduced in #5063

@erikjohnston erikjohnston merged commit a1eb4c6 into develop Apr 16, 2019

24 checks passed

buildkite/synapse Build #994 passed (18 minutes, 9 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 12 seconds)
Details
buildkite/synapse/isort Passed (15 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (14 seconds)
Details
buildkite/synapse/packaging Passed (16 seconds)
Details
buildkite/synapse/pep-8 Passed (52 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 26 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 22 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (12 minutes, 57 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (7 minutes, 58 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 24 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 19 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (16 minutes, 57 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (17 minutes, 5 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (13 minutes, 16 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 4 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (9 minutes, 28 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 6e27a86...468b2bc
Details
codecov/project 61.56% (target 0%)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.