Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of request.postpath #5070

Merged
merged 2 commits into from Apr 17, 2019

Conversation

Projects
None yet
2 participants
@erikjohnston
Copy link
Member

commented Apr 16, 2019

This is an undocumented variable in twisted, and relies on the servlet
being mounted in the right way.

This also broke getting push rules on workers. Introduced in #5063


Ideally we would fix this up to not do custom url parsing and instead have it use the regex and/or separate servlets. However, let's just do the quick fix for now

erikjohnston added some commits Apr 16, 2019

Remove usage of request.postpath
This is an undocumented variable in twisted, and relies on the servlet
being mounted in the right way.

This also breaks getting push rules on workers.

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Apr 16, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 16, 2019

Codecov Report

Merging #5070 into develop will decrease coverage by 0.08%.
The diff coverage is 40%.

@@             Coverage Diff             @@
##           develop    #5070      +/-   ##
===========================================
- Coverage    61.57%   61.48%   -0.09%     
===========================================
  Files          332      332              
  Lines        34271    34228      -43     
  Branches      5651     5647       -4     
===========================================
- Hits         21103    21046      -57     
- Misses       11653    11674      +21     
+ Partials      1515     1508       -7
@richvdh
Copy link
Member

left a comment

plausible

@erikjohnston erikjohnston merged commit fd2fcb8 into develop Apr 17, 2019

24 checks passed

buildkite/synapse Build #1020 passed (13 minutes, 58 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 13 seconds)
Details
buildkite/synapse/isort Passed (18 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (14 seconds)
Details
buildkite/synapse/packaging Passed (17 seconds)
Details
buildkite/synapse/pep-8 Passed (53 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (12 minutes)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 6 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 51 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (8 minutes, 29 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 44 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 45 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 45 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 46 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 30 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 39 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 35 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 40% of diff hit (target 0%)
Details
codecov/project 61.48% (target 0%)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.