Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we're not registering the same 3pid twice #5071

Merged
merged 1 commit into from Apr 17, 2019

Conversation

Projects
None yet
2 participants
@babolivier
Copy link
Member

commented Apr 17, 2019

If a user hits /register/{medium}/requestToken twice then clicks on each link from the two activation emails, they would register the same 3pid twice because we only check that in calls to requestToken.

@babolivier babolivier requested a review from matrix-org/synapse-core Apr 17, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 17, 2019

Codecov Report

Merging #5071 into develop will decrease coverage by 1.14%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #5071      +/-   ##
===========================================
- Coverage    61.57%   60.43%   -1.15%     
===========================================
  Files          332      328       -4     
  Lines        34271    34096     -175     
  Branches      5651     5628      -23     
===========================================
- Hits         21103    20605     -498     
- Misses       11653    12020     +367     
+ Partials      1515     1471      -44

@babolivier babolivier force-pushed the babolivier/3pid-check branch from 5b0bead to 600ec04 Apr 17, 2019

@babolivier babolivier merged commit 49ff74d into develop Apr 17, 2019

24 checks passed

buildkite/synapse Build #1044 passed (13 minutes, 16 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 12 seconds)
Details
buildkite/synapse/isort Passed (19 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (18 seconds)
Details
buildkite/synapse/packaging Passed (16 seconds)
Details
buildkite/synapse/pep-8 Passed (53 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (10 minutes, 57 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 5 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 14 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (8 minutes, 18 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (11 minutes, 47 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (11 minutes, 41 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 14 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 7 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 5 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 37 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 54 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 0% of diff hit (target 0%)
Details
codecov/project 60.43% (target 0%)
Details

@babolivier babolivier deleted the babolivier/3pid-check branch Apr 29, 2019

@babolivier babolivier restored the babolivier/3pid-check branch Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.