Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some endpoints for account validity management #5073

Merged
merged 2 commits into from Apr 17, 2019

Conversation

Projects
None yet
2 participants
@babolivier
Copy link
Member

commented Apr 17, 2019

GET /_matrix/client/unstable/account_validity/send_mail (needs auth):

  • triggers sending a renewal email to the user that made the request
  • 200 response format: {}

POST /_matrix/client/unstable/admin/account_validity/validity (needs auth from a server admin):

See https://github.com/matrix-org/synapse/blob/babolivier/account_expiration/docs/admin_api/account_validity.rst

@babolivier babolivier requested a review from matrix-org/synapse-core Apr 17, 2019

@babolivier babolivier force-pushed the babolivier/account_expiration branch from af5d18e to 563628a Apr 17, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 17, 2019

Codecov Report

Merging #5073 into develop will increase coverage by 0.03%.
The diff coverage is 88%.

@@             Coverage Diff             @@
##           develop    #5073      +/-   ##
===========================================
+ Coverage    61.67%   61.71%   +0.03%     
===========================================
  Files          334      334              
  Lines        34431    34476      +45     
  Branches      5666     5670       +4     
===========================================
+ Hits         21235    21276      +41     
- Misses       11674    11676       +2     
- Partials      1522     1524       +2
@erikjohnston
Copy link
Member

left a comment

Assuming it passes CI, lgtm

@babolivier babolivier requested a review from matrix-org/synapse-core Apr 17, 2019

@erikjohnston erikjohnston force-pushed the babolivier/account_expiration branch from d8cacf7 to b570270 Apr 17, 2019

@erikjohnston erikjohnston force-pushed the babolivier/account_expiration branch from b570270 to ca90336 Apr 17, 2019

@babolivier babolivier merged commit 8383a55 into develop Apr 17, 2019

24 checks passed

buildkite/synapse Build #1064 passed (14 minutes)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 14 seconds)
Details
buildkite/synapse/isort Passed (33 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (14 seconds)
Details
buildkite/synapse/packaging Passed (35 seconds)
Details
buildkite/synapse/pep-8 Passed (54 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 48 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 32 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 56 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (8 minutes, 18 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 46 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 54 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 47 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 57 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 54 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 21 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 42 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 88% of diff hit (target 0%)
Details
codecov/project 61.71% (target 0%)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.