Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash on lack of expiry templates #5077

Merged
merged 1 commit into from Apr 18, 2019

Conversation

Projects
None yet
2 participants
@babolivier
Copy link
Member

commented Apr 18, 2019

Fixes #5076

@babolivier babolivier requested a review from matrix-org/synapse-core Apr 18, 2019

@babolivier babolivier force-pushed the babolivier/account_expiration branch from 0288902 to f8826d3 Apr 18, 2019

@babolivier babolivier merged commit 1a63c7c into develop Apr 18, 2019

22 checks passed

buildkite/synapse Build #1071 passed (19 minutes, 21 seconds)
Details
buildkite/synapse/check-sample-config Passed (10 minutes, 23 seconds)
Details
buildkite/synapse/isort Passed (16 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (51 seconds)
Details
buildkite/synapse/packaging Passed (3 minutes, 28 seconds)
Details
buildkite/synapse/pep-8 Passed (56 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (12 minutes, 1 second)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 7 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (7 minutes, 23 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (8 minutes, 16 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 43 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 50 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 19 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (8 minutes, 4 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 46 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 53 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 31 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
@codecov

This comment has been minimized.

Copy link

commented Apr 18, 2019

Codecov Report

Merging #5077 into develop will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           develop    #5077   +/-   ##
========================================
  Coverage    61.71%   61.71%           
========================================
  Files          334      334           
  Lines        34476    34476           
  Branches      5670     5670           
========================================
  Hits         21276    21276           
+ Misses       11676    11673    -3     
- Partials      1524     1527    +3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.