Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Added possibilty to disable local password authentication #5092
This change allows to disable the local password authentication which is useful when password providers are used.
I would also qualify this feature as a bug because it allows the following use-case
The real solution would be to change the password_auth_provider api. Because you should not try to authenticate against the next provider when a user was already found in a previous provider. But the check_password/auth/etc interface only returns true/false and nothing in between which could stop the validate_login loop
Pull Request Checklist
@@ Coverage Diff @@ ## develop #5092 +/- ## =========================================== - Coverage 63.19% 63.16% -0.04% =========================================== Files 328 328 Lines 35932 35935 +3 Branches 5909 5910 +1 =========================================== - Hits 22708 22698 -10 - Misses 11599 11611 +12 - Partials 1625 1626 +1