Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workarounds for pep-517 errors #5098

Merged
merged 3 commits into from Apr 25, 2019

Conversation

Projects
None yet
2 participants
@richvdh
Copy link
Member

commented Apr 25, 2019

No description provided.

richvdh added some commits Apr 25, 2019

set PIP_USE_PEP517 = False for tests
pip 19.1 otherwise complains about "editable mode is not supported for
pyproject.toml-style projects"

@richvdh richvdh requested a review from matrix-org/synapse-core Apr 25, 2019

@babolivier
Copy link
Member

left a comment

lgtm

@codecov

This comment has been minimized.

Copy link

commented Apr 25, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (develop@4a9a118). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #5098   +/-   ##
==========================================
  Coverage           ?   61.68%           
==========================================
  Files              ?      334           
  Lines              ?    34512           
  Branches           ?     5680           
==========================================
  Hits               ?    21288           
  Misses             ?    11695           
  Partials           ?     1529

@richvdh richvdh merged commit 2ebf7d5 into develop Apr 25, 2019

24 checks passed

buildkite/synapse Build #1126 passed (13 minutes, 23 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 9 seconds)
Details
buildkite/synapse/isort Passed (15 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (12 seconds)
Details
buildkite/synapse/packaging Passed (18 seconds)
Details
buildkite/synapse/pep-8 Passed (51 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 19 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 34 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 27 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (7 minutes, 49 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 11 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 10 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 18 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 19 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 18 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 11 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 4 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected.
Details
codecov/project 61.68% (target 0%)
Details

babolivier added a commit that referenced this pull request Apr 25, 2019

Merge pull request #5098 from matrix-org/rav/fix_pep_517
Workarounds for pep-517 errors

babolivier added a commit that referenced this pull request Apr 30, 2019

Merge pull request #5098 from matrix-org/rav/fix_pep_517
Workarounds for pep-517 errors

babolivier added a commit that referenced this pull request May 8, 2019

Merge pull request #5098 from matrix-org/rav/fix_pep_517
Workarounds for pep-517 errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.