Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging when event-signature checking fails #5100

Merged
merged 4 commits into from Apr 29, 2019

Conversation

2 participants
@richvdh
Copy link
Member

commented Apr 25, 2019

There are basically two changes here:

  • The change in keyring.py is a refactor of verify_json_objects_for_server, the main purpose of which is that when there are no signatures at all from the relevant server, we shortcut _handle_key_deferred and instead just return a failure which tells us what happened.

  • The changes in federation_base catch the failures returned by verify_json_objects_for_server and turn them into new exceptions which tell you which event caused the problem.

richvdh added some commits Apr 25, 2019

@richvdh richvdh requested a review from matrix-org/synapse-core Apr 25, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 25, 2019

Codecov Report

Merging #5100 into develop will decrease coverage by 0.01%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           develop    #5100      +/-   ##
===========================================
- Coverage    61.67%   61.65%   -0.02%     
===========================================
  Files          334      334              
  Lines        34512    34521       +9     
  Branches      5680     5680              
===========================================
  Hits         21284    21284              
- Misses       11699    11708       +9     
  Partials      1529     1529

@richvdh richvdh added this to In progress in Homeserver Task Board via automation Apr 25, 2019

@richvdh richvdh merged commit b31cc1c into develop Apr 29, 2019

24 checks passed

buildkite/synapse Build #1141 passed (22 minutes, 19 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 11 seconds)
Details
buildkite/synapse/isort Passed (55 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (12 seconds)
Details
buildkite/synapse/packaging Passed (52 seconds)
Details
buildkite/synapse/pep-8 Passed (55 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 39 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 11 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 42 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (8 minutes, 14 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 50 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 34 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 52 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 45 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 53 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 22 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 49 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 50% of diff hit (target 0%)
Details
codecov/project 61.65% (target 0%)
Details

Homeserver Task Board automation moved this from In progress to Done Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.