Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ratelimit 3pid invites #5104

Merged
merged 4 commits into from May 7, 2019

Conversation

Projects
None yet
2 participants
@erikjohnston
Copy link
Member

commented Apr 26, 2019

We do ratelimit sending the 3PID invite events, but that happens after
spamming the identity server.

erikjohnston added some commits Apr 26, 2019

Ratelimit 3pid invites
We do ratelimit sending the 3PID invite events, but that happens after
spamming the identity server.

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Apr 26, 2019

@babolivier babolivier requested a review from matrix-org/synapse-core Apr 26, 2019

@babolivier
Copy link
Member

left a comment

lgtm, then

@codecov

This comment has been minimized.

Copy link

commented May 2, 2019

Codecov Report

Merging #5104 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #5104      +/-   ##
===========================================
+ Coverage    61.67%   61.68%   +<.01%     
===========================================
  Files          334      334              
  Lines        34514    34517       +3     
  Branches      5681     5681              
===========================================
+ Hits         21288    21291       +3     
  Misses       11696    11696              
  Partials      1530     1530

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core May 2, 2019

@erikjohnston erikjohnston merged commit de655e6 into develop May 7, 2019

24 checks passed

buildkite/synapse Build #1218 passed (13 minutes, 39 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 13 seconds)
Details
buildkite/synapse/isort Passed (17 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (14 seconds)
Details
buildkite/synapse/packaging Passed (17 seconds)
Details
buildkite/synapse/pep-8 Passed (53 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 33 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 42 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 47 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (8 minutes, 12 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 27 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 24 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 35 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 32 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 20 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 25 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (8 minutes, 24 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 61.68% (target 0%)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.