Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the admin API to `/_synapse/admin/v1` #5119

Merged
merged 6 commits into from May 2, 2019

Conversation

Projects
None yet
2 participants
@richvdh
Copy link
Member

commented May 1, 2019

Fixes #4850. Note that the existing endpoints will still work, for now at least.

Note to the reviewer: There are three commits here, which are probably easier to review individually. The first tweaks the implementations so that they no longer depend on ClientV1RestServlet, which is a bit of a solution looking for a problem anyway. The second commit adds the new prefix to the endpoints. The third commit moves the impl to a different package, since it was confusing to have it under synapse.rest.client.v1.

@richvdh richvdh requested a review from matrix-org/synapse-core May 1, 2019

@codecov

This comment has been minimized.

Copy link

commented May 1, 2019

Codecov Report

Merging #5119 into develop will increase coverage by <.01%.
The diff coverage is 94.73%.

@@             Coverage Diff             @@
##           develop    #5119      +/-   ##
===========================================
+ Coverage    61.65%   61.65%   +<.01%     
===========================================
  Files          334      334              
  Lines        34523    34531       +8     
  Branches      5681     5682       +1     
===========================================
+ Hits         21284    21290       +6     
- Misses       11709    11711       +2     
  Partials      1530     1530

@richvdh richvdh merged commit 1df2f80 into develop May 2, 2019

24 checks passed

buildkite/synapse Build #1187 passed (13 minutes, 36 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 9 seconds)
Details
buildkite/synapse/isort Passed (15 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (14 seconds)
Details
buildkite/synapse/packaging Passed (17 seconds)
Details
buildkite/synapse/pep-8 Passed (50 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 44 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 38 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 31 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (7 minutes, 56 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 15 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 18 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 21 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 21 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 26 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 25 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 33 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 94.73% of diff hit (target 0%)
Details
codecov/project 61.65% (target 0%)
Details

@richvdh richvdh deleted the rav/admin_api_urls branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.