Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out an "assert_requester_is_admin" function #5120

Merged
merged 5 commits into from May 2, 2019

Conversation

Projects
None yet
2 participants
@richvdh
Copy link
Member

commented May 1, 2019

Rather than copying-and-pasting the same four lines hundreds of times

Builds on #5119.

Factor out an "assert_requester_is_admin" function
Rather than copying-and-pasting the same four lines hundreds of times

@richvdh richvdh requested a review from matrix-org/synapse-core May 1, 2019

@codecov

This comment has been minimized.

Copy link

commented May 1, 2019

Codecov Report

Merging #5120 into develop will increase coverage by 0.06%.
The diff coverage is 51.72%.

@@             Coverage Diff             @@
##           develop    #5120      +/-   ##
===========================================
+ Coverage    61.65%   61.72%   +0.06%     
===========================================
  Files          334      335       +1     
  Lines        34531    34502      -29     
  Branches      5682     5669      -13     
===========================================
+ Hits         21290    21295       +5     
+ Misses       11711    11681      -30     
+ Partials      1530     1526       -4

richvdh added some commits May 2, 2019

@richvdh richvdh merged commit 0836cbb into develop May 2, 2019

24 checks passed

buildkite/synapse Build #1210 passed (17 minutes, 6 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 15 seconds)
Details
buildkite/synapse/isort Passed (16 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (13 seconds)
Details
buildkite/synapse/packaging Passed (16 seconds)
Details
buildkite/synapse/pep-8 Passed (56 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (12 minutes, 10 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 7 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 19 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (8 minutes, 15 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 7 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 37 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 14 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 32 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 44 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 14 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 24 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 51.72% of diff hit (target 0%)
Details
codecov/project 61.72% (target 0%)
Details

@richvdh richvdh deleted the rav/assert_requester_is_admin branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.