Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin api for sending server_notices #5121

Merged
merged 4 commits into from May 2, 2019

Conversation

Projects
None yet
2 participants
@richvdh
Copy link
Member

commented May 1, 2019

Hopefully fairly self-explanatory. Based on #5120.

Fixes #3532.

@richvdh richvdh force-pushed the rav/send_server_notices_api branch from 459367c to 924468b May 1, 2019

@codecov

This comment has been minimized.

Copy link

commented May 1, 2019

Codecov Report

Merging #5121 into develop will decrease coverage by 0.02%.
The diff coverage is 40%.

@@             Coverage Diff             @@
##           develop    #5121      +/-   ##
===========================================
- Coverage    61.72%   61.69%   -0.03%     
===========================================
  Files          335      336       +1     
  Lines        34502    34539      +37     
  Branches      5669     5671       +2     
===========================================
+ Hits         21295    21310      +15     
- Misses       11678    11703      +25     
+ Partials      1529     1526       -3

@richvdh richvdh requested a review from matrix-org/synapse-core May 1, 2019

@richvdh richvdh force-pushed the rav/send_server_notices_api branch from 64a742b to dd4c6ee May 2, 2019

@richvdh richvdh merged commit 12f9d51 into develop May 2, 2019

24 checks passed

buildkite/synapse Build #1214 passed (32 minutes, 18 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 9 seconds)
Details
buildkite/synapse/isort Passed (15 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (15 seconds)
Details
buildkite/synapse/packaging Passed (16 seconds)
Details
buildkite/synapse/pep-8 Passed (49 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 37 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 33 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 24 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (7 minutes, 39 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 19 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 39 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 22 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 5 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (27 minutes, 59 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 13 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 58 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 40% of diff hit (target 0%)
Details
codecov/project 61.69% (target 0%)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.