Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI after new release of isort #5179

Merged
merged 3 commits into from May 13, 2019

Conversation

Projects
None yet
2 participants

@babolivier babolivier requested a review from matrix-org/synapse-core May 13, 2019

@richvdh
Copy link
Member

left a comment

lgtm modulo changelog type

Show resolved Hide resolved changelog.d/5179.bugfix Outdated
@codecov

This comment has been minimized.

Copy link

commented May 13, 2019

Codecov Report

Merging #5179 into develop will decrease coverage by 0.68%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #5179      +/-   ##
===========================================
- Coverage    61.75%   61.06%   -0.69%     
===========================================
  Files          336      336              
  Lines        34639    34639              
  Branches      5692     5692              
===========================================
- Hits         21390    21154     -236     
- Misses       11721    11924     +203     
- Partials      1528     1561      +33
@codecov

This comment has been minimized.

Copy link

commented May 13, 2019

Codecov Report

Merging #5179 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #5179   +/-   ##
========================================
  Coverage    61.75%   61.75%           
========================================
  Files          336      336           
  Lines        34639    34639           
  Branches      5692     5692           
========================================
  Hits         21390    21390           
+ Misses       11721    11718    -3     
- Partials      1528     1531    +3

@babolivier babolivier merged commit 8cc9ba3 into develop May 13, 2019

24 checks passed

buildkite/synapse Build #1344 passed (14 minutes, 4 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 12 seconds)
Details
buildkite/synapse/isort Passed (14 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (16 seconds)
Details
buildkite/synapse/packaging Passed (16 seconds)
Details
buildkite/synapse/pep-8 Passed (53 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (12 minutes, 7 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 17 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (8 minutes, 46 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (7 minutes, 56 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (13 minutes, 3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (13 minutes, 5 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 24 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 20 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (13 minutes)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (13 minutes, 3 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 12 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 9a18e1d...2725cd2
Details
codecov/project 61.75% (target 0%)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.