Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Track deactivated accounts in the database #5378
It would be handy to be able to track deactivated account in the database. For example, an upcoming work on account validity is to ignore deactivated accounts when creating entries in the
every time we need to do that check, which sounds quite expensive to me.
This does not turn the value to
referenced this pull request
Jun 7, 2019
@@ Coverage Diff @@ ## dinsic #5378 +/- ## ========================================= Coverage ? 63.18% ========================================= Files ? 326 Lines ? 35700 Branches ? 5857 ========================================= Hits ? 22557 Misses ? 11556 Partials ? 1587
erikjohnston left a comment
This looks good, but I do think we want to have a background update for setting the deactivated flags for existing users. This would involve checking each user to see if they have no password, no access tokens and no threepids.
Otherwise, we're going to start depending on the new column, forgetting that there are existing users that have been deactivated without the field being set.
Everything currently there looks good!