Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add a mechanism for per-test configs #5657
I also added a mechanism in the backoff PR -- https://github.com/matrix-org/synapse/pull/5556/files#diff-9161fd33123787f063a0f71aad7c3272R382 -- obviously we should pick one of them :)
I'm not in love with attaching objects to functions, personally, so IDK.
Well, obviously we should land this one, because it's not tied up into a larger, more contentious, PR ;)
Building a config, configuring the HS, and then reconfiguring the HS feels like a bit of a funny way of doing things to me.
I agree that attaching things to functions isn't super-lovely either, though in practice (https://github.com/matrix-org/synapse/pull/5660/files#diff-afaefb43d2d504f504fb4d4a8840e70eR222) it felt quite usable.
Perhaps a casting vote? @erikjohnston ?
@@ Coverage Diff @@ ## develop #5657 +/- ## =========================================== + Coverage 63.22% 63.26% +0.04% =========================================== Files 331 328 -3 Lines 36037 35853 -184 Branches 5931 5909 -22 =========================================== - Hits 22784 22684 -100 + Misses 11623 11545 -78 + Partials 1630 1624 -6