Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging in workers #5729

Merged
merged 12 commits into from Jul 22, 2019
@@ -220,16 +220,17 @@ steps:
env:
POSTGRES: "1"
WORKERS: "1"
BLACKLIST: "synapse-blacklist-with-workers"
command:
- "bash .buildkite/merge_base_branch.sh"
- "bash -c 'cat /src/sytest-blacklist /src/worker-blacklist > /src/synapse-blacklist-with-workers'"
- "bash /synapse_sytest.sh"
plugins:
- docker#v3.0.1:
image: "matrixdotorg/sytest-synapse:py35"
propagate-environment: true
always-pull: true
workdir: "/src"
soft_fail: true
retry:
automatic:
- exit_status: -1
@@ -8,6 +8,7 @@ include demo/demo.tls.dh
include demo/*.py
include demo/*.sh
include sytest-blacklist
include worker-blacklist

This comment has been minimized.

Copy link
@richvdh

richvdh Jul 22, 2019

Member

except it's now under .buildkite ?


recursive-include synapse/storage/schema *.sql
recursive-include synapse/storage/schema *.sql.postgres
@@ -0,0 +1 @@
Fix worker log config not being set correctly.
This conversation was marked as resolved by hawkowl

This comment has been minimized.

Copy link
@richvdh

richvdh Jul 22, 2019

Member

probably wants merging with the PR that broke it rather than being a new changelog entry?

This comment has been minimized.

Copy link
@hawkowl

hawkowl Jul 22, 2019

Author Contributor

err yes, done

@@ -31,6 +31,7 @@ def read_config(self, config, **kwargs):
self.worker_listeners = config.get("worker_listeners", [])
self.worker_daemonize = config.get("worker_daemonize")
self.worker_pid_file = config.get("worker_pid_file")
self.worker_log_config = config.get("worker_log_config")

# The host used to connect to the main synapse
self.worker_replication_host = config.get("worker_replication_host", None)
@@ -0,0 +1,26 @@
# This file serves as a blacklist for SyTest tests that we expect will fail in
This conversation was marked as resolved by hawkowl

This comment has been minimized.

Copy link
@richvdh

richvdh Jul 22, 2019

Member

could these go somewhere other than the root of the repository? There's enough clutter there already.

This comment has been minimized.

Copy link
@hawkowl

hawkowl Jul 22, 2019

Author Contributor

done

# Synapse when run under worker mode. For more details, see sytest-blacklist.

Message history can be paginated

m.room.history_visibility == "world_readable" allows/forbids appropriately for Guest users

m.room.history_visibility == "world_readable" allows/forbids appropriately for Real users

Can re-join room if re-invited

/upgrade creates a new room

The only membership state included in an initial sync is for all the senders in the timeline

Local device key changes get to remote servers

If remote user leaves room we no longer receive device updates

Forgotten room messages cannot be paginated

Inbound federation can get public room list

Members from the gap are included in gappy incr LL sync

Leaves are present in non-gapped incremental syncs
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.