/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Mitigate against incorrect old state in /sync. #573

Merged
merged 1 commit into from Feb 18, 2016

Conversation

Reviewers
No reviews
Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented Feb 12, 2016

There have been reports from the field that servers occasionally have incorrect notions of what the old state of a room is. This proves problematic as /sync relies on a correct old state.
This patch makes /sync specifically include in the 'state' key any current state events that haven't been correctly included.
@erikjohnston
Mitigate against incorrect old state in /sync. 
There have been reports from the field that servers occasionally have
incorrect notions of what the old state of a room is. This proves
problematic as /sync relies on a correct old state.
This patch makes /sync specifically include in the 'state' key any
current state events that haven't been correctly included.
4d54d87

@erikjohnston erikjohnston assigned NegativeMjark Feb 12, 2016

@NegativeMjark
Contributor

NegativeMjark commented Feb 12, 2016

LGTM
@erikjohnston
Owner

erikjohnston commented Feb 18, 2016

@matrixbot test this please

erikjohnston added a commit that referenced this pull request Feb 18, 2016

@erikjohnston
Merge pull request #573 from matrix-org/erikj/sync_fix 
Mitigate against incorrect old state in /sync.
220231d

@erikjohnston erikjohnston merged commit 220231d into develop Feb 18, 2016
1 check passed

1 check passed

default Merged build finished.
Details

@richvdh richvdh deleted the erikj/sync_fix branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment