Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix Synapse hang during startup. #5867
Hmm, that's somewhat annoying. This was introduced in 80cfad2, basically the idea was that we wouldn't consider ourselves "up" until all the setup code had run (so that e.g. systemd would do the right thing if synapse fails to start vs dies after start). We could shuffle things around and basically implement the "before start" stuff ourselves, but I was hoping that I could just reuse the twisted builtin stuff for this.
I'd be interested to know if this is expected behaviour (@hawkowl?)
Broadly: if this is breaking things then its fine for this PR to land and we can try to figure out how to fix the functionality separately.