Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Synapse hang during startup. #5867

Closed

Conversation

@chrismoos
Copy link
Contributor

commented Aug 16, 2019

Fixes #5866

Fix issue with Synapse not starting up. Fixes #5866.
Signed-off-by: Chris Moos <chris@chrismoos.com>

@chrismoos chrismoos changed the base branch from master to develop Aug 16, 2019

@richvdh

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

@erikjohnston I think you made this change. WDYT?

@richvdh richvdh requested a review from erikjohnston Aug 16, 2019

@richvdh

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

I'm guessing the problem is that the dns lookups don't run until the reactor is properly 'started' so we can't do the acme request before that?

@erikjohnston

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

Hmm, that's somewhat annoying. This was introduced in 80cfad2, basically the idea was that we wouldn't consider ourselves "up" until all the setup code had run (so that e.g. systemd would do the right thing if synapse fails to start vs dies after start). We could shuffle things around and basically implement the "before start" stuff ourselves, but I was hoping that I could just reuse the twisted builtin stuff for this.

I'd be interested to know if this is expected behaviour (@hawkowl?)

Broadly: if this is breaking things then its fine for this PR to land and we can try to figure out how to fix the functionality separately.

@richvdh

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

Thanks for this. I've cherry-picked it into a branch based on the current release, so it will be in v1.3.1.

@richvdh richvdh closed this Aug 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.