Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on sdnotify #5871

Merged
merged 4 commits into from Aug 17, 2019

Conversation

@richvdh
Copy link
Member

commented Aug 16, 2019

... to save OSes which don't use it from having to maintain a port.

Fixes #5865.

richvdh added 3 commits Aug 16, 2019
Drop dependency on sdnotify
... to save OSes which don't use it from having to maintain a port.

Fixes #5865.

@richvdh richvdh requested a review from matrix-org/synapse-core Aug 16, 2019

@babolivier
Copy link
Member

left a comment

lgtm

@richvdh richvdh merged commit 412c6e2 into release-v1.3.1 Aug 17, 2019

17 checks passed

buildkite/synapse Build #3476 passed (14 minutes, 34 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 6 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 13 seconds)
Details
buildkite/synapse/isort Passed (19 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (18 seconds)
Details
buildkite/synapse/packaging Passed (22 seconds)
Details
buildkite/synapse/pipeline Passed (8 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (13 minutes, 10 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (5 minutes, 45 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (4 minutes, 52 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (3 minutes, 26 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (11 minutes, 32 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (10 minutes, 45 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (5 minutes, 38 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (6 minutes, 5 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (7 minutes, 4 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (4 minutes, 57 seconds)
Details
@bachp bachp referenced this pull request Aug 17, 2019
4 of 10 tasks complete

@richvdh richvdh added this to In progress in Homeserver Task Board via automation Aug 22, 2019

@richvdh richvdh moved this from In progress to Done in Homeserver Task Board Aug 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.