Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
handlers/_base: don't allow room create event to be changed #596
Conversation
matrixbot
commented
Feb 22, 2016
|
Can one of the admins verify this patch? |
|
@matrixbot ok to test |
erikjohnston
added a commit
that referenced
this pull request
Mar 4, 2016
erikjohnston
merged commit 44b084a
into
matrix-org:develop
Mar 4, 2016
matrixbot
referenced this pull request
Nov 7, 2016
Open
shouldn't m.room.create be immutable? (SYN-636) #1503
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Rugvip commentedFeb 22, 2016
Beginning of the m.room.create spec says
This could arguably be interpreted as that specific event not being changed, or the m.room.create state as a whole. I chose to interpret it as the latter, which I also think makes sense, as it is currently possible to e.g. change the creator key of the create state.
In either case this is a spec bug as well.