Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

handlers/_base: don't allow room create event to be changed #596

Merged
merged 1 commit into from Mar 4, 2016

Conversation

Projects
None yet
3 participants
Contributor

Rugvip commented Feb 22, 2016

Beginning of the m.room.create spec says

This is the first event in a room and cannot be changed.

This could arguably be interpreted as that specific event not being changed, or the m.room.create state as a whole. I chose to interpret it as the latter, which I also think makes sense, as it is currently possible to e.g. change the creator key of the create state.

In either case this is a spec bug as well.

Can one of the admins verify this patch?

handlers/_base: don't allow room create event to be changed
Signed-off-by: Patrik Oldsberg <patrik.oldsberg@ericsson.com>
Owner

erikjohnston commented Feb 23, 2016

@matrixbot ok to test

erikjohnston added a commit that referenced this pull request Mar 4, 2016

Merge pull request #596 from Rugvip/create
handlers/_base: don't allow room create event to be changed

@erikjohnston erikjohnston merged commit 44b084a into matrix-org:develop Mar 4, 2016

2 checks passed

Synapse Build #6098 succeeded in 4 min 56 sec
Details
default Build finished. 324 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment