Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set m.require_identity_server to always be False #5968

Closed

Conversation

@anoadragon453
Copy link
Member

commented Sep 3, 2019

As MSC2263 states, m.require_identity_server must be set to false when it does not require an identity server to be provided by the client for the purposes of email registration or password reset.

We were setting this on the basis of account_threepid_delegate being set or not, but it should actually just always be false as anoa/reg_email feature branch lets the homeserver decide what upstream identity server it should use for these tasks.

@anoadragon453 anoadragon453 requested a review from matrix-org/synapse-core Sep 3, 2019
@anoadragon453 anoadragon453 added this to In progress in Homeserver Task Board via automation Sep 3, 2019
@anoadragon453 anoadragon453 changed the title Set flag to always be False Set m.require_identity_server to always be False Sep 3, 2019
@richvdh

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

anoa/reg_email feature branch lets the homeserver decide what upstream identity server it should use for these tasks.

Please can you link to the PR that made this change?

@anoadragon453

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

Sorry, that would be #5876

@richvdh

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Sorry, that would be #5876

id_server still seems to be mandatory in user-interactive auth there? https://github.com/matrix-org/synapse/pull/5876/files#diff-09aa21e5bb05afad9baeb8141a43480fR42 etc

@anoadragon453

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

Hm, looks like I missed that :|

@anoadragon453

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

Kind of annoying as both the v2 identity stuff and email registration things have stake in how this works.

@anoadragon453 anoadragon453 self-assigned this Sep 3, 2019
@anoadragon453 anoadragon453 removed the request for review from matrix-org/synapse-core Sep 3, 2019
@anoadragon453

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

Superseded by #5972

Homeserver Task Board automation moved this from In progress to Done Sep 3, 2019
@anoadragon453 anoadragon453 deleted the anoa/m_require_identity_server_false branch Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.