Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move lookup-related functions from RoomMemberHandler to IdentityHandler #5978

Merged
merged 5 commits into from Sep 27, 2019

Conversation

@anoadragon453
Copy link
Member

anoadragon453 commented Sep 4, 2019

Just to have all the methods that make calls to identity services in one place.

@anoadragon453

This comment has been minimized.

Copy link
Member Author

anoadragon453 commented Sep 26, 2019

Removing tags as this is just a general cleanup job at this moment and not blocking the sprint.

@anoadragon453 anoadragon453 force-pushed the anoa/lookup_to_identity_handler branch from ee499bf to 163cd4f Sep 26, 2019
@anoadragon453 anoadragon453 marked this pull request as ready for review Sep 26, 2019
@anoadragon453 anoadragon453 requested a review from matrix-org/synapse-core Sep 26, 2019
@anoadragon453 anoadragon453 force-pushed the anoa/lookup_to_identity_handler branch from d64f6a0 to 9c16e00 Sep 26, 2019
Copy link
Member

richvdh left a comment

I'm taking it on trust that you are able to ctrl-x ctrl-v correctly

@anoadragon453

This comment has been minimized.

Copy link
Member Author

anoadragon453 commented Sep 27, 2019

I'm taking it on trust that you are able to ctrl-x ctrl-v correctly

Goodness no sir, I used <shift>v<ctrl>ddgfo<esc>p. For you see, I use vim.

@anoadragon453 anoadragon453 merged commit 8c27bc8 into develop Sep 27, 2019
20 checks passed
20 checks passed
buildkite/synapse Build #4643 passed (17 minutes, 58 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 18 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 19 seconds)
Details
buildkite/synapse/isort Passed (19 seconds)
Details
buildkite/synapse/mypy Passed (25 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (18 seconds)
Details
buildkite/synapse/packaging Passed (20 seconds)
Details
buildkite/synapse/pipeline Passed (9 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (16 minutes, 9 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (4 minutes, 50 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (7 minutes, 9 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (4 minutes, 39 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (16 minutes, 9 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (15 minutes, 48 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (4 minutes, 33 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (9 minutes, 24 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (9 minutes, 6 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (8 minutes, 22 seconds)
Details
buildkite/synapse/trigger-webhook Passed (7 seconds)
Details
coverage/coveralls Coverage increased (+0.04%) to 64.637%
Details
Homeserver Task Board automation moved this from In progress to Done Sep 27, 2019
@anoadragon453 anoadragon453 deleted the anoa/lookup_to_identity_handler branch Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.