Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
config,handlers/_base: added homeserver config for what state is included in a room invite #598
Conversation
matrixbot
commented
Feb 23, 2016
|
Can one of the admins verify this patch? |
|
@matrixbot ok to test |
|
@Rugvip LGTM, will merge if jenkins is happy |
|
Needs #599 |
|
Actually wth, added that commit into this instead :p |
Rugvip
referenced this pull request
Feb 23, 2016
Closed
handlers/sync: style fix, line too long #599
|
This breaks our unit tests; can you throw in this patch?: $ git diff
diff --git a/tests/utils.py b/tests/utils.py
index bf7a31f..11d9acb 100644
--- a/tests/utils.py
+++ b/tests/utils.py
@@ -50,6 +50,7 @@ def setup_test_homeserver(name="test", datastore=None, config=None, **kargs):
config.macaroon_secret_key = "not even a little secret"
config.server_name = "server.under.test"
config.trusted_third_party_id_servers = []
+ config.room_invite_state_types = []
if "clock" not in kargs:
kargs["clock"] = MockClock() |
|
Before merging this, we should update the spec to actually articulate what's allowed to go into an invite and not. Agreed that it'd be nice to have this extensibility, but want to do so without creating a spam vector or encouraging fragmentation. Created a https://matrix.org/jira/browse/SPEC-357 spec bug first. |
|
@Rugvip Can you fix the merge conflicts? |
matrixbot
commented
Mar 4, 2016
|
Can one of the admins verify this patch? |
Rugvip
added some commits
Feb 23, 2016
|
LGTM |
Rugvip commentedFeb 23, 2016
Related SPEC bug: https://matrix.org/jira/browse/SPEC-357