/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make sure we return a JSON object when returning the values of specif… #606

Merged
merged 1 commit into from Feb 25, 2016

Conversation

Reviewers
No reviews
Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@NegativeMjark @dbkr
@NegativeMjark
Contributor

NegativeMjark commented Feb 25, 2016

…ic keys from a push rule

@NegativeMjark NegativeMjark assigned dbkr Feb 25, 2016

@dbkr
Member

dbkr commented Feb 25, 2016

Presumably this is changing what the API returns, in line with the enabled change? If so, fine as long as this is reflected in the spec.

@dbkr dbkr assigned NegativeMjark and unassigned dbkr Feb 25, 2016

@NegativeMjark
Contributor

NegativeMjark commented Feb 25, 2016

If so, fine as long as this is reflected in the spec.

It matches the spec added in matrix-org/matrix-doc#282.

I don't believe that this bit of the API was specified before then.

NegativeMjark added a commit that referenced this pull request Feb 25, 2016

@NegativeMjark
Merge pull request #606 from matrix-org/markjh/get_enabled 
Make sure we return a JSON object when returning the values of specif…

…ic keys from a push rule
faa3d17

@NegativeMjark NegativeMjark merged commit faa3d17 into develop Feb 25, 2016
1 check was pending

1 check was pending

default Build triggered. sha1 is merged.
Details

@richvdh richvdh deleted the markjh/get_enabled branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment